-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues#1627] Change log level from error to debug inside ImportDMNResolverUtil #6172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yesamer
on second thought, I think we have to change the overall approach here.
That method get's invoked twice, once with an empty Collection<T> dmns
and once with a populated one.
The "misleading" logs are related to the first one.
So, I think it is better that, when an empty dmns collections is recieved, the method immediately returns back with an Either.of left, and debug messaging explaining it.
If, instead, a populated collection is received, all failures on finding imported model should be logged as error: wdyt ?
@gitgabrio The improvement you suggested makes sense, but I would manage it in this ticket apache/incubator-kie-issues#1383 (please feel free to update it) and provide a complete refactoring of the feature |
@yesamer |
@gitgabrio Done, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yesamer
lgtm!
@baldimir Can you please review it? |
…de ImportDMNResolverUtil (apache#6172) * change log level * change log level * change log level
Closes apache/incubator-kie-issues#1627
Follow up of #6150, discovered during apache/incubator-kie-issues#1627 testing.
Based on the current architecture, the
resolveImportDMN(Import, Collection<T>, Function<T, QName>)
is called twice, which means that an error logged in the first call is inconsistent with the second call, where the behavior works as expected.As a consequence, all log levels should be set as DEBUG, until a definitive fix in the architecture.