Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-parser] Primary rule should accept this keyword #5791

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

yurloc
Copy link
Contributor

@yurloc yurloc commented Mar 18, 2024

Fixes #5702.

Allows this to appear as primary, for example in String(this == "x").

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

As in `String(this == "x")`.
@yurloc
Copy link
Contributor Author

yurloc commented Mar 18, 2024

@tkobayas please review.

@tkobayas tkobayas self-requested a review March 18, 2024 09:30
@tkobayas tkobayas merged commit 3ac65e9 into apache:dev-new-parser Mar 18, 2024
0 of 3 checks passed
@yurloc yurloc deleted the primary-this branch March 18, 2024 10:09
@yurloc
Copy link
Contributor Author

yurloc commented Mar 18, 2024

Fixing progress: There were 410 failed tests (-18 approximately).

@yurloc yurloc changed the title Primary rule should accept this keyword [new-parser] Primary rule should accept this keyword Mar 18, 2024
tkobayas pushed a commit to tkobayas/drools that referenced this pull request Jun 11, 2024
tkobayas pushed a commit to tkobayas/drools that referenced this pull request Oct 2, 2024
tkobayas pushed a commit to tkobayas/drools that referenced this pull request Oct 11, 2024
tkobayas pushed a commit that referenced this pull request Oct 11, 2024
As in `String(this == "x")`.
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants