[incubator-kie-issues#780] DMN - Benchmarking InfixOpNode and InfixOperators #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariofusco
approved these changes
Dec 18, 2023
mariofusco
requested changes
Dec 18, 2023
There was a problem hiding this comment.
This benchmark is actually pretty useless for how it is written. All variables are null so every expression evaluation does an early return here https://github.com/apache/incubator-kie-drools/pull/5621/files#diff-c6e01aff43f0da99ce7ea8c1a565968943e760e14ef102214110b8d167f0397cR64
Please put some values in the context before evaluating the expressions.
gitgabrio
changed the title
|
Continued here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add InfixOpNode specific benchmark
Fixes apache/incubator-kie-issues#780