Wildfly 8 Support (Partial) #621
Conversation
|
incubator-brooklyn-pull-requests #1092 FAILURE |
|
incubator-brooklyn-pull-requests #1094 FAILURE |
|
incubator-brooklyn-pull-requests #1095 SUCCESS |
|
incubator-brooklyn-pull-requests #1097 FAILURE |
|
incubator-brooklyn-pull-requests #1099 SUCCESS |
| new PortAttributeSensorAndConfigKey("webapp.jboss.managementNativePort", "Management native port", "10999+"); | ||
|
|
||
| /** | ||
| * Port increments are the standard way to run multiple instances of AS7 on the same machine. |
There was a problem hiding this comment.
Wildlfy, rather than AS7.
| /** | ||
| * A simple test of installing+running Wildfly 8 on Docker, using various OS distros and versions. | ||
| */ | ||
| public class Wildfly8ServerDockerLiveTest extends JBossServerDockerLiveTest { |
There was a problem hiding this comment.
As with the Wildfly AWS test, will this fail because the attributes aren't being set? In which case we should include a comment explaining why.
Could also parameterise the super.doTest() to say whether to assert those attributes are non-null.
There was a problem hiding this comment.
Moved all to WIP with explanation.
|
Thanks @mikezaccardo - looking good. A few minor comments, some of which should be addressed and many of which should be deferred. You said in the description that the live tests "will not yet pass due to the missing metrics". Given we'll not get those metrics out of Wildfly in the short term, is there something we should do to get the live tests passing? For example, parameterise the Would be good to have some tests that pass, so we can regression test this after it's been merged. |
|
As per discussion with @aledsage, this is not going to be merged just yet. I will work adding tests that will pass given the incomplete state of Wildfly's metrics, and cleanup whatever else is deemed necessary. |
|
incubator-brooklyn-pull-requests #1363 FAILURE |
|
incubator-brooklyn-pull-requests #1377 SUCCESS |
Wildfly 8 is now partially supported.
brooklyn.entity.webapp.jboss.Wildfly8Servercan now be used in place ofbrooklyn.entity.webapp.jboss.JBoss7Serverin the example blueprints.However, Wildfly 8's Undertow subsystem does not yet provide several required statistics that are used by certain policies -- for example, an auto-scaling policy configured to use the requests-per-second metric would not yet work.
The JBoss / Wildfly live tests have been refactored and Wildfly 8 live tests have been added (integration tests not yet added). Note that they will not yet pass due to the missing metrics.
See: https://issues.apache.org/jira/browse/BROOKLYN-142