[WIP] Parameterize the start effector #1128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygy
force-pushed
the
feature/start-effector
branch
from
002937d to
fa253d9
Compare
ygy
changed the title
- customize.skip as Brooklyn config key - if customize.skip is set to true for an entity the driver will skip the the customize commands - added skipInstallation as a parameter to the SoftwareProcess start effector - if skipInstallation is used during the start effector invoking install.skip and customize.skip parameters will be set to true so install and customize phases are skipped and only launch is executed
ygy
force-pushed
the
feature/start-effector
branch
from
fa253d9 to
62bffcc
Compare
|
LGTM |
| @@ -140,7 +141,10 @@ public void attachLifecycleEffectors(Entity entity) { | |||
| * the behaviour in this lifecycle class instance. | |||
| */ | |||
| public Effector<Void> newStartEffector() { | |||
| return Effectors.effector(Startable.START).impl(newStartEffectorTask()).build(); | |||
| return Effectors.effector(Startable.START) | |||
| .parameter(StartSoftwareParameters.SKIP_INSTALLATION) | |||
There was a problem hiding this comment.
A better place for this would be the SoftwareProcessDriverLifecycleEffectorTasks (overriding the method there), but given that the rest of the lifecycle effectors set their process related parameters here ok to stay here for consistency.
|
Overall it's a very useful thing to have when doing support. Don't like how the effector has side effects which will influence how future calls behave. Would be nice if the SKIP_CUSTOMIZE config is kept, but set out of the effector - either through curl of groovy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip the the customize commands
effector
install.skip and customize.skip parameters will be set to true so
install and customize phases are skipped and only launch is
executed