Spark: Rewrite V2 deletes to V3 DVs #12250
Open
+463
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
rewrite-position-deletes-to-dvs
branch
4 times, most recently
from
48f9fb6 to
d2910f8
Compare
...rk/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java
Outdated
Show resolved
Hide resolved
| @@ -213,45 +217,61 @@ static class PositionDeletesWriterFactory implements DataWriterFactory { | |||
| this.writeProperties = writeProperties; | |||
| } | |||
|
|
|||
| private Table underlyingTable(Table table) { | |||
There was a problem hiding this comment.
I'm a little concerned here because it appears this has two negative impacts:
- This results in a distributed load of the table metadata
- This relies on loading from the metadata file location directly, which we're trying to remove from other actions.
There was a problem hiding this comment.
Yeah I'm a bit confused why we couldn't just leverage the existing table broadcast? If it's a different type of Table, does broadcasting the underlying table work instead?
There was a problem hiding this comment.
I've updated this so that we fetch the format version not on the executors but rather earlier
nastra
force-pushed
the
rewrite-position-deletes-to-dvs
branch
2 times, most recently
from
37eb0d2 to
95ff7d4
Compare
nastra
force-pushed
the
rewrite-position-deletes-to-dvs
branch
from
95ff7d4 to
4b0819a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.