Core: Remove TableMetadata::Builder::resetMainBranch
#12149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaheshwar-pltr
force-pushed
the
delegate-to-remove-ref
branch
from
546fab7 to
6af6913
Compare
ebyhr
reviewed
Feb 2, 2025
| } | ||
|
|
||
| return this; | ||
| return removeRef(SnapshotRef.MAIN_BRANCH); |
There was a problem hiding this comment.
We could remove resetMainBranch method. The logic between removeRef(SnapshotRef.MAIN_BRANCH) and resetMainBranch() were different until #11779. They are same now.
There was a problem hiding this comment.
Yes - happy to make this change
There was a problem hiding this comment.
Good find, yes I don't see a good reason to keep resetMainBranch around anymore especially since it's a private method. let's just remove it!
There was a problem hiding this comment.
Done! d753324
smaheshwar-pltr
changed the title
resetMainBranch to removeRef in TableMetadata::BuilderTableMetadata::Builder::resetMainBranch
amogh-jahagirdar
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks @smaheshwar-pltr @ebyhr ! I'll leave it open for a bit in case others had any thoughts
ebyhr
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The private method
TableMetadata::Builder::resetMainBranchused once is equivalent toTableMetadata::Builder::removeRef(SnapshotRef.MAIN_BRANCH), so this PR removes it.