Spark: Test metadata tables with format-version=3 #12135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Jan 30, 2025
...5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java
Show resolved
Hide resolved
nastra
commented
Jan 30, 2025
| @@ -84,6 +84,9 @@ public InternalRow next() { | |||
| rowValues.add(deleteFile.contentOffset()); | |||
| } else if (fieldId == MetadataColumns.CONTENT_SIZE_IN_BYTES_COLUMN_ID) { | |||
| rowValues.add(ScanTaskUtil.contentSizeInBytes(deleteFile)); | |||
| } else if (fieldId == MetadataColumns.DELETE_FILE_ROW_FIELD_ID) { | |||
| // DVs don't track the row that was deleted | |||
| rowValues.add(null); | |||
There was a problem hiding this comment.
this fixes an issue when reading from the .position_deletes table when the underlying table is V3. By default, the schema includes
...5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
spark-metadata-tables
branch
from
95e7d3a to
654a1ed
Compare
amogh-jahagirdar
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.