Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datafusion): Support cast operations #821

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Dec 18, 2024

Resolves #811

Depends on #820

@Fokko Fokko force-pushed the fd-extend-converter branch from 24d103d to 073e4ee Compare December 18, 2024 12:34
@Xuanwo Xuanwo changed the title Datafusion: Support cast operations feat(datafusion): Support cast operations Dec 20, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Dec 20, 2024

#820 has been merged.

@Fokko Fokko marked this pull request as draft December 20, 2024 16:17
@Fokko
Copy link
Contributor Author

Fokko commented Dec 20, 2024

@Xuanwo Thanks, I was noodling a bit on this one, I want to make some changes to make it safer for the user before marking this as ready.

@ryzhyk
Copy link
Contributor

ryzhyk commented Jan 2, 2025

@Fokko , thanks again for working on this. I am very much looking forward to this PR landing (due to #811). Any chance you could finalize it soon? Thanks!

@Fokko Fokko marked this pull request as ready for review January 17, 2025 11:11
@Fokko
Copy link
Contributor Author

Fokko commented Jan 17, 2025

@ryzhyk @Xuanwo Sorry about that, I think this is actually good to go 👍

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fokko for fixing this!

@liurenjie1024 liurenjie1024 merged commit cc73766 into apache:main Jan 18, 2025
17 checks passed
@Fokko Fokko deleted the fd-extend-converter branch January 20, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issue with range queries over a partitioned table.
5 participants