Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPCLIENT-2070: Auth cache to no longer rely on Java serialization for auth state caching #544

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

ok2c
Copy link
Member

@ok2c ok2c commented Jan 30, 2024

No more Java serialization in HttpClient

@ok2c ok2c requested a review from arturobernalg January 30, 2024 14:22
@ok2c
Copy link
Member Author

ok2c commented Jan 30, 2024

@arturobernalg Please take a look.

Copy link
Member

@arturobernalg arturobernalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ok2c
LGTM

@Internal
public static class State {

final Map<String, String> params;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this variables are not private due to its internal scope.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturobernalg Correct.

@Internal
public static class State {

final Map<String, String> params;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this variables are not private due to its internal scope.

@ok2c ok2c merged commit 23da984 into apache:master Jan 31, 2024
9 checks passed
@ok2c ok2c deleted the HTTPCLIENT-2070 branch January 31, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants