Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zstd support to ContentCompressionExec. #498

Closed
wants to merge 1 commit into from

Conversation

arturobernalg
Copy link
Member

This update allows automatic selection of Zstd as a compression algorithm when available.

This update allows automatic selection of Zstd as a compression algorithm when available.
@garydgregory
Copy link
Member

Why not do this through Commons Compress?

@arturobernalg arturobernalg marked this pull request as ready for review October 31, 2023 16:26
@arturobernalg
Copy link
Member Author

arturobernalg commented Oct 31, 2023

Why not do this through Commons Compress?

In general keep it simple. Adding a direct dependency on the Zstd library is a straightforward way to enable ` 'Zstd' compression without the overhead of an additional module.

@ok2c
Copy link
Member

ok2c commented Nov 2, 2023

@arturobernalg Zstd appears to be BSD Licensed. It should be compatible with ASLv2 but I am afraid this needs to be double-checked.

Why indeed not using Apache Compress if it provides compatible compression codec?

@garydgregory
Copy link
Member

Hi all,

Commons Compress depends on the same lib BUT provides a facade API for all its archive and compressed file formats.

@ok2c
Copy link
Member

ok2c commented Nov 2, 2023

Hi all,

Commons Compress depends on the same lib BUT provides a facade API for all its archive and compressed file formats.

@garydgregory Got it. Thank you.

@arturobernalg
Copy link
Member Author

@arturobernalg Zstd appears to be BSD Licensed. It should be compatible with ASLv2 but I am afraid this needs to be double-checked.

Why indeed not using Apache Compress if it provides compatible compression codec?

Well, my initial approach was to directly integrate the Zstd library to provide a direct and potentially efficient solution. I see what i can do.

Thank you

@arturobernalg arturobernalg marked this pull request as draft November 6, 2023 20:16
@ok2c
Copy link
Member

ok2c commented Dec 13, 2023

@arturobernalg Could you please change the target branch to master so I could delete obsolete 5.4.x?

@ok2c ok2c deleted the branch apache:5.4.x December 19, 2023 09:38
@ok2c ok2c closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants