Refactor RequestIfRange class to use DateUtils for date parsing. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arturobernalg
commented
Oct 24, 2023
arturobernalg
commented
- Updates the RequestIfRange class to utilize DateUtils for parsing standard HTTP dates.
- Optimize time difference check in RequestIfRange with Instant API.
ok2c
reviewed
Oct 24, 2023
|
|
||
| if (dateHeader == null) { | ||
| return; | ||
| } | ||
|
|
||
| final Instant lastModifiedHeader = DateUtils.parseStandardDate(request, HttpHeaders.LAST_MODIFIED); |
There was a problem hiding this comment.
@arturobernalg lastModifiedHeader is likely not the best name now. lastModifiedInstant? Same deal with dateHeader. dateInstant?
There was a problem hiding this comment.
@ok2c Agree.
Changed.
ok2c
approved these changes
Oct 24, 2023
arturobernalg
force-pushed
the
request-if-range-date-refactor
branch
from
3911e7c to
9801783
Compare
* Updates the RequestIfRange class to utilize DateUtils for parsing standard HTTP dates. * Optimize time difference check in RequestIfRange with Instant API.
arturobernalg
force-pushed
the
request-if-range-date-refactor
branch
from
9801783 to
ad3f1ca
Compare
ok2c
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Updates the RequestIfRange class to utilize DateUtils for parsing standard HTTP dates. * Optimize time difference check in RequestIfRange with Instant API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.