HADOOP-19431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-distcp. #7368

slfan1989 · 2025-02-08T00:40:35Z

Description of PR

JIRA: HADOOP-19431. Upgrade JUnit from 4 to 5 in hadoop-distcp.

How was this patch tested?

Junit Test & mvn clean test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2025-02-08T03:00:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 32 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 5s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	0m 31s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	0m 52s		trunk passed
+1 💚	shadedclient	33m 49s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 22s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	0m 21s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	0m 19s	/results-checkstyle-hadoop-tools_hadoop-distcp.txt	hadoop-tools/hadoop-distcp: The patch generated 85 new + 272 unchanged - 9 fixed = 357 total (was 281)
+1 💚	mvnsite	0m 23s		the patch passed
+1 💚	javadoc	0m 21s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	0m 47s		the patch passed
+1 💚	shadedclient	33m 36s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	24m 19s	/patch-unit-hadoop-tools_hadoop-distcp.txt	hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		138m 25s

Reason	Tests
Failed junit tests	hadoop.tools.TestDistCpSystem
	hadoop.tools.TestIntegration
	hadoop.tools.util.TestDistCpUtilsWithCombineMode
	hadoop.tools.TestCopyListing

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/1/artifact/out/Dockerfile
GITHUB PR	#7368
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 710c27ea8366 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `889e430`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/1/testReport/
Max. process+thread count	553 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-02-08T07:56:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 32 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 52s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	0m 31s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 30s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	0m 51s		trunk passed
+1 💚	shadedclient	33m 28s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	0m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 19s	/results-checkstyle-hadoop-tools_hadoop-distcp.txt	hadoop-tools/hadoop-distcp: The patch generated 20 new + 268 unchanged - 18 fixed = 288 total (was 286)
+1 💚	mvnsite	0m 23s		the patch passed
+1 💚	javadoc	0m 22s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	0m 48s		the patch passed
+1 💚	shadedclient	33m 19s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	26m 11s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		139m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/2/artifact/out/Dockerfile
GITHUB PR	#7368
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ffd94fda9ed4 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `023b1c9`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/2/testReport/
Max. process+thread count	674 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-02-08T12:21:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 32 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 35s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	0m 31s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	0m 51s		trunk passed
+1 💚	shadedclient	33m 31s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 22s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	0m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 18s	/results-checkstyle-hadoop-tools_hadoop-distcp.txt	hadoop-tools/hadoop-distcp: The patch generated 1 new + 259 unchanged - 27 fixed = 260 total (was 286)
+1 💚	mvnsite	0m 24s		the patch passed
+1 💚	javadoc	0m 21s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	0m 48s		the patch passed
+1 💚	shadedclient	33m 41s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	25m 53s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		139m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/3/artifact/out/Dockerfile
GITHUB PR	#7368
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 55af729924d6 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `53f18d6`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/3/testReport/
Max. process+thread count	633 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-02-08T15:11:28Z

@cnauroth Can you help review this PR? Thank you very much!

hadoop-yetus · 2025-02-08T17:20:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 32 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 46s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	0m 31s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	0m 50s		trunk passed
+1 💚	shadedclient	33m 21s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	0m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 18s		hadoop-tools/hadoop-distcp: The patch generated 0 new + 259 unchanged - 27 fixed = 259 total (was 286)
+1 💚	mvnsite	0m 24s		the patch passed
+1 💚	javadoc	0m 21s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	0m 49s		the patch passed
+1 💚	shadedclient	33m 41s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	26m 2s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		139m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/4/artifact/out/Dockerfile
GITHUB PR	#7368
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 24c77a56d159 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `55a05f7`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/4/testReport/
Max. process+thread count	661 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth

+1, with one minor change requested.

Additionally, is there a JUnit 4 dependency that should be removed from hadoop-distcp/pom.xml?

cnauroth · 2025-02-09T20:45:21Z

hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java

@@ -119,6 +119,16 @@ protected SimpleCopyListing(Configuration configuration,
    this.randomizeFileListing = randomizeFileListing;
  }

+  protected void initSimpleCopyListing(Configuration pConfiguration,


Can you please mark this as VisibleForTesting?

Maybe TestCopyListing shouldn't be extending SimpleCopyListing, but no need to take on further refactoring right now.

Can you please mark this as VisibleForTesting?

Thank you for your explanation! I have added the VisibleForTesting annotation above the initSimpleCopyListing function.

Maybe TestCopyListing shouldn't be extending SimpleCopyListing, but no need to take on further refactoring right now.

This is a great suggestion! I will record it as a to-do. Once we complete the upgrade from JUnit4 to JUnit5, we will implement this optimization.

slfan1989 · 2025-02-09T23:30:07Z

+1, with one minor change requested.

Additionally, is there a JUnit 4 dependency that should be removed from hadoop-distcp/pom.xml?

@cnauroth We cannot remove the JUnit4 dependency from the pom file yet because hadoop-distcp has two test dependencies on hadoop-common. I am still following up on this in #7375, but it does not affect PR #7368. My plan is to try removing the JUnit4 dependencies from some modules once we complete the upgrade of the hadoop-common dependency.

…pyListing.

hadoop-yetus · 2025-02-10T02:04:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 13s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 32 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 21s		trunk passed
+1 💚	compile	0m 44s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 32s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 53s		trunk passed
+1 💚	shadedclient	33m 42s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 19s		hadoop-tools/hadoop-distcp: The patch generated 0 new + 259 unchanged - 27 fixed = 259 total (was 286)
+1 💚	mvnsite	0m 23s		the patch passed
+1 💚	javadoc	0m 21s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 48s		the patch passed
+1 💚	shadedclient	33m 10s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	25m 33s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		150m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/5/artifact/out/Dockerfile
GITHUB PR	#7368
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 6a723b011399 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7d8d0c2`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/5/testReport/
Max. process+thread count	728 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7368/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth · 2025-02-10T04:30:11Z

+1, with one minor change requested.
Additionally, is there a JUnit 4 dependency that should be removed from hadoop-distcp/pom.xml?

@cnauroth We cannot remove the JUnit4 dependency from the pom file yet because hadoop-distcp has two test dependencies on hadoop-common. I am still following up on this in #7375, but it does not affect PR #7368. My plan is to try removing the JUnit4 dependencies from some modules once we complete the upgrade of the hadoop-common dependency.

Oh, that makes perfect sense. Thank you!

cnauroth

+1

slfan1989 · 2025-02-10T05:34:34Z

@cnauroth Thank you very much for reviewing the code! I have merged this PR into the trunk branch to proceed with the work of upgrading JUnit4 to JUnit5 in other modules.

HADOOP-19431. Upgrade JUnit from 4 to 5 in hadoop-distcp.

889e430

github-actions bot added DistCp trunk TOOLS labels Feb 8, 2025

slfan1989 changed the title ~~HADOOP-19431. Upgrade JUnit from 4 to 5 in hadoop-distcp.~~ HADOOP-19431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-distcp. Feb 8, 2025

HADOOP-19431. Fix Unit test.

febabee

HADOOP-19431. Fix Unit test & CheckStyle.

023b1c9

slfan1989 marked this pull request as ready for review February 8, 2025 05:35

HADOOP-19431. Fix CheckStyle.

53f18d6

HADOOP-19431. Fix CheckStyle.

55a05f7

slfan1989 mentioned this pull request Feb 9, 2025

[DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. #7337

Draft

74 tasks

cnauroth approved these changes Feb 9, 2025

View reviewed changes

HADOOP-19431. Add VisibleForTesting On SimpleCopyListing#initSimpleCo…

7d8d0c2

…pyListing.

cnauroth approved these changes Feb 10, 2025

View reviewed changes

slfan1989 merged commit c5fdc3b into apache:trunk Feb 10, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-19431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-distcp. #7368

HADOOP-19431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-distcp. #7368

slfan1989 commented Feb 8, 2025 •

edited

Loading

hadoop-yetus commented Feb 8, 2025

hadoop-yetus commented Feb 8, 2025

hadoop-yetus commented Feb 8, 2025

slfan1989 commented Feb 8, 2025

hadoop-yetus commented Feb 8, 2025

cnauroth left a comment

cnauroth Feb 9, 2025

slfan1989 Feb 9, 2025

slfan1989 commented Feb 9, 2025

hadoop-yetus commented Feb 10, 2025

cnauroth commented Feb 10, 2025

cnauroth left a comment

slfan1989 commented Feb 10, 2025

HADOOP-19431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-distcp. #7368

HADOOP-19431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-distcp. #7368

Conversation

slfan1989 commented Feb 8, 2025 • edited Loading

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented Feb 8, 2025

hadoop-yetus commented Feb 8, 2025

hadoop-yetus commented Feb 8, 2025

slfan1989 commented Feb 8, 2025

hadoop-yetus commented Feb 8, 2025

cnauroth left a comment

Choose a reason for hiding this comment

cnauroth Feb 9, 2025

Choose a reason for hiding this comment

slfan1989 Feb 9, 2025

Choose a reason for hiding this comment

slfan1989 commented Feb 9, 2025

hadoop-yetus commented Feb 10, 2025

cnauroth commented Feb 10, 2025

cnauroth left a comment

Choose a reason for hiding this comment

slfan1989 commented Feb 10, 2025

slfan1989 commented Feb 8, 2025 •

edited

Loading