-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part4. #7356
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
838c059
to
80ac7bf
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@cnauroth Could you please help review this PR? Thank you very much! There are still some checkstyle issues remaining, and I will continue to follow up and resolve them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Thank you @slfan1989 !
a6030d7
to
2107f18
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@cnauroth Thank you very much for reviewing the code! The Checkstyle issues in this PR have been resolved, and Yetus has provided a successful build result. I have merged this PR into the trunk branch to facilitate the development of Part5/Part6. |
Description of PR
JIRA: HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part4.
How was this patch tested?
Junit Test & mvn clean test
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?