[#6361] feat(paimon):Support specifying primary keys during create paimon table by flink #6362
+138
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate paimon table by flink
…ate paimon table by flink
…ate paimon table by flink
FANNG1
reviewed
Jan 24, 2025
| @@ -280,6 +281,69 @@ public void testCreateSimpleTable() { | |||
| supportDropCascade()); | |||
| } | |||
|
|
|||
| @Test | |||
| @EnabledIf("supportTableOperation") | |||
| public void testCreateTableWithPrimaryKey() { | |||
There was a problem hiding this comment.
I'm afraid Hive or Iceberg doesn't support Specifying Primary key. maybe we could move this test to Paimon IT only.
FANNG1
reviewed
Jan 24, 2025
server/build.gradle.kts
Outdated
| @@ -28,6 +28,7 @@ dependencies { | |||
| implementation(project(":common")) | |||
| implementation(project(":core")) | |||
| implementation(project(":server-common")) | |||
| implementation(libs.mysql.driver) | |||
There was a problem hiding this comment.
please remove this, Gravitino server doesn't rely on mysql.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support specifying primary keys during create paimon table by flink
Why are the changes needed?
Fix: #6361
Does this PR introduce any user-facing change?
None
How was this patch tested?
Add testCreateTableWithPrimaryKey case in org.apache.gravitino.flink.connector.integration.test.FlinkCommonIT