Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6067] improve(CLI): Support model pre event to Gravitino server #6250

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[#6067] improve(CLI): Support model pre event to Gravitino server #6250

wants to merge 7 commits into from

Conversation

Abyss-lord
Copy link
Contributor

What changes were proposed in this pull request?

Support model pre event to Gravitino server, based on #6129 , Both synchronize Dispatcher changes with each other

ModelInfo, ModelVersionInfo

image

PreEvent

image

PreEvent OperationType ModelCatalog
RegisterModelPreEvent REGISTER_MODEL registerModel
GetModelPreEvent LOAD_MODEL getModel
DeleteModelEvent Delete_MODEL deleteModel
ListModelPreEvent LIST_MODEL listModels
LinkModelVersionPreEvent LINK_MODEL_VERSION linkModelVersion
GetModelVersionPreEvent GET_MODEL_VERSION getModelVersion
DeleteModelVersionPreEvent Delete_MODEL_VERSION deleteModelVersion
ListModelVersionsPreEvent LIST_MODEL_VERSIONS listModelVersions

ModelEventDispatcher

image

Why are the changes needed?

Fix: #6067

Does this PR introduce any user-facing change?

No

How was this patch tested?

Model Event

  1. testRegisterModelEvent
  2. testGetModelEvent
  3. testDeleteExistsModelEvent
  4. testDeleteNotExistsModelEvent
  5. testListModelEvent

Model Version Event

  1. testLinkModelVersionEvent
  2. testGetModelVersionEventViaVersion
  3. testGetModelVersionEventViaAlias
  4. testDeleteModelVersionEventViaVersion
  5. testDeleteModelVersionEventViaAlias
  6. testDeleteModelVersionEventViaVersionNotExists
  7. testListModelVersionsEvent

@Abyss-lord
[apache#6078] feat(core): Support model event to Gravitino server
559bd90 
Support model event to Gravitino server. Add list, get, create and delete events to both model and model version.
@Abyss-lord
[apache#6078] feat(core): Support model event to Gravitino server
596abb0 
Fix some class comments.
@Abyss-lord
[apache#6078] feat(core): Support model event to Gravitino server
b85a34f 
Fix some error.
@Abyss-lord
[apache#6078] feat(core): Support model event to Gravitino server
6b672fe 
Fix some error and add ModelEventDispatcher to Gravitino server.
@Abyss-lord
[apache#6220] improve(CLI): Clean up GravitinoCommandLine class now i…
b28b189 
…t been refactored

rename drop event and operation type.
@Abyss-lord
[apache#6067] improve(CLI): Support model pre event to Gravitino server
6b6a154 
Support model pre event to Gravitino server.

[apache#6067] improve(CLI): Support model pre event to Gravitino server

add model version related pre event to Gravitino server.

[apache#6067] improve(CLI): Support model pre event to Gravitino server

add preEvent support for ModelEventDispatcher.

[apache#6067] improve(CLI): Support model pre event to Gravitino server

add test cases.
@Abyss-lord
[apache#6067] improvement(core): Support model pre event to Gravitino…
416d3b4 
… server

fix some issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Abyss-lord