[#6229] docs: add fileset credential vending example #6231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
yuqi1129
reviewed
Jan 14, 2025
|
|
||
| ### How to access ADLS fileset with credential | ||
| ```shell |
There was a problem hiding this comment.
Should we need to move this example forward and put it with example without credential?
There was a problem hiding this comment.
If we mix the example with the example without credentials, it will be hard to distinguish them especially in fileset client side
|
@mchades Would you like to take a look? |
yuqi1129
reviewed
Jan 14, 2025
docs/hadoop-catalog-with-adls.md
Outdated
| ```shell | ||
| curl -X POST -H "Accept: application/vnd.gravitino.v1+json" \ | ||
| -H "Content-Type: application/json" -d '{ | ||
| "name": "example_catalog", |
There was a problem hiding this comment.
Could you please rename example_catalog to make it related to adls? the same goes for S3, GCS and OSS.
yuqi1129
approved these changes
Jan 14, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
### What changes were proposed in this pull request? add credential vending document for fileset ### Why are the changes needed? Fix: #6229 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? just document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add credential vending document for fileset
Why are the changes needed?
Fix: #6229
Does this PR introduce any user-facing change?
no
How was this patch tested?
just document