[#6220] improve(CLI): Clean up GravitinoCommandLine class now it been refactored #6227
+134
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t been refactored 1. Clean up GravitinoCommandLine class. 2. add SimpleCommandHandler to handle simple commands.
…t been refactored fix some issue.
|
@justinmclean @tengqm could you please review this PR when you have time? I’d really appreciate your feedback. |
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
Outdated
Show resolved
Hide resolved
…t been refactored fix some issue.
tengqm
reviewed
Jan 14, 2025
clients/cli/src/main/java/org/apache/gravitino/cli/SimpleCommandHandler.java
Show resolved
Hide resolved
justinmclean
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clean up GravitinoCommandLine class now it been refactored
Why are the changes needed?
Fix: #6220
Does this PR introduce any user-facing change?
No
How was this patch tested?
local ut test.