[#6139] Refactor metalake command in Gravitino CLI #6140
Conversation
|
@shaofengshi and @tengqm what do you think of this? It's mostly cosmetic but does make it easier to understand. |
@justinmclean Should we split other commands？ |
| * Constructs a MetalakeCommandHandler instance. | ||
| * | ||
| * @param gravitinoCommandLine The Gravitino command line instance. | ||
| * @param line The command line options. |
There was a problem hiding this comment.
rename line to options or arguments ?
There was a problem hiding this comment.
The variable name line is used elsewhere e.g. FullName, GravitinoCommandLine and Main, options might be a little confusing as that is a different class.
|
@Abyss-lord You can start working on the other sub-issues for this if you want. |
|
@shaofengshi can you review this? |
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/CommandHandler.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
|
@shaofengshi Other people are waiting on this PR. It should only take a few minutes to review. @jerryshao if @shaofengshi is busy, can you suggest someone else to review it. |
|
/lgtm |
### What changes were proposed in this pull request? The Gravitino command line class is a little large and could be broken up. ### Why are the changes needed? For readability and maintainability. Fix: apache#6139 ### Does this PR introduce _any_ user-facing change? None. ### How was this patch tested? Tested locally. --------- Co-authored-by: Shaofeng Shi <[email protected]>
What changes were proposed in this pull request?
The Gravitino command line class is a little large and could be broken up.
Why are the changes needed?
For readability and maintainability.
Fix: #6139
Does this PR introduce any user-facing change?
None.
How was this patch tested?
Tested locally.