Skip to content

Commit

Permalink
[#6237]fix: add missing @OverRide annotations (#6244)
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

Add missing `@override` annotations

### Why are the changes needed?

Fix:  #6237

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
N/A
  • Loading branch information
sunxiaojian authored and web-flow committed Jan 15, 2025
1 parent 7668082 commit 5e35c34
Show file tree
Hide file tree
Showing 10 changed files with 11 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,14 @@ public RangerClientExtension(String hostName, String authType, String username,
}
}

@Override
public RangerPolicy createPolicy(RangerPolicy policy) throws RangerServiceException {
Preconditions.checkArgument(
policy.getResources().size() > 0, "Ranger policy resources can not be empty!");
return super.createPolicy(policy);
}

@Override
public RangerPolicy updatePolicy(long policyId, RangerPolicy policy)
throws RangerServiceException {
Preconditions.checkArgument(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ public VXGroup() {
*
* @return formatedStr
*/
@Override
public String toString() {
String str = "VXGroup={";
str += super.toString();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ public String getName() {
*
* @return formatedStr
*/
@Override
public String toString() {
String str = "VXUser={";
str += super.toString();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ protected Map<String, String> getTableProperties(Connection connection, String t
}
}

@Override
protected void correctJdbcTableFields(
Connection connection, String databaseName, String tableName, JdbcTable.Builder tableBuilder)
throws SQLException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ public void disableMetalake(NameIdentifier ident) throws NoSuchMetalakeException
dispatcher.disableMetalake(ident);
}

@Override
public boolean dropMetalake(NameIdentifier ident) {
// For metalake, we don't clear all the privileges of catalog authorization plugin.
// we just remove metalake.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public TableInfo createTableRequest() {
return createTableRequest;
}

@Override
public OperationType operationType() {
return OperationType.CREATE_TABLE;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public String insertCatalogMetaOnDuplicateKeyUpdate(CatalogPO catalogPO) {
+ " deleted_at = #{catalogMeta.deletedAt}";
}

@Override
public String updateCatalogMeta(
@Param("newCatalogMeta") CatalogPO newCatalogPO,
@Param("oldCatalogMeta") CatalogPO oldCatalogPO) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public String insertMetalakeMetaOnDuplicateKeyUpdate(MetalakePO metalakePO) {
+ " deleted_at = #{metalakeMeta.deletedAt}";
}

@Override
public String updateMetalakeMeta(
@Param("newMetalakeMeta") MetalakePO newMetalakePO,
@Param("oldMetalakeMeta") MetalakePO oldMetalakePO) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import org.apache.ibatis.annotations.Param;

public class SecurableObjectPostgreSQLProvider extends SecurableObjectBaseSQLProvider {
@Override
public String batchSoftDeleteSecurableObjects(
@Param("securableObjects") List<SecurableObjectPO> securableObjectPOs) {
return "<script>"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public String insertTagMetaOnDuplicateKeyUpdate(TagPO tagPO) {
+ " deleted_at = #{tagMeta.deletedAt}";
}

@Override
public String updateTagMeta(
@Param("newTagMeta") TagPO newTagPO, @Param("oldTagMeta") TagPO oldTagPO) {
return "UPDATE "
Expand Down

0 comments on commit 5e35c34

Please sign in to comment.