Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new generated sources created from
freemarker-javax-servlet
where javax references are replaced with jakarta references. Tests are also copied (with similar adjustments).The main remaining question is
freemarker.cache.WebappTemplateLoader
. For now, I have left it in the same package renamed toJakartaWebappTemplateLoader
. There are two reasons for this:freemarker.cache
is a split package, and it is awkward to deal with this, if we move this class to a new package.freemarker.cache
(URLTemplateSource
andTemplateLoaderUtils
), and making them public is an obvious detriment.That said, I do have a variant of this change where I moved this class into another package (in my local copy), so moving to a new package is definitely doable, if the used classes (and their methods) are made public.