[BUILD] sign and rat-check on CI build #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarwell
force-pushed
the
2.3-dist-rat-github-action
branch
2 times, most recently
from
c432d46 to
9acd24b
Compare
bmarwell
force-pushed
the
2.3-dist-rat-github-action
branch
from
9acd24b to
43e57dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ddekany this PR enhances the CI by using the
_disttarget internally. This was made possible by skipping the interactive check when aciproperty is present.The way this project is set up, the RAT check can only be done when
_distwas run, so it was now added to the workflow file as well. We could add it to thecitarget instead, but I feel it should be separate for clarity.Todo:
ant.project.invoked-targetsinstead for the presence ofci.