-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] add github workflow #100
Conversation
abbfdd8
to
b5e13aa
Compare
836facf
to
3ac52b8
Compare
3ac52b8
to
a33970d
Compare
Because of the prompt, I was not able to add the "dist" goal. However, the signing could be done by a passphrase-less gpg key. This is needed for a rat-check. Skipped it for now. |
Tests with other JDKs (11, 17, 21) can be added in another commit, if you are interested. |
Thanks! BTW, Travis ran very long ago, when it was still free, but it's green build icon is still there. If there something like that Git actions, it should be replaced to with that. |
Sure! Can do that in another PR, preferably. Otherwise I'd do it blindly. I would love to add the "ant dist" target. The only thing I can't do is "answer yes" on the last question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should also remove Travis.
We can add a cache in a later PR, but for now this should be fine. Maybe not even worth it as the project is heading towards Gradle. |
We don't need |
Just a suggestion. This way further pull requests will automatically be checked.