FINERACT-1981: fix progressive installment reschedule #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Jan 21, 2025
| @@ -293,6 +294,11 @@ public BigDecimal getAnnualNominalInterestRate() { | |||
| : BigDecimal.valueOf(Double.parseDouble(this.annualNominalInterestRate.stripTrailingZeros().toString())); | |||
| } | |||
|
|
|||
| @Override | |||
| public LoanTermVariationsDataWrapper getLoanTermVariationsDataWrapper() { | |||
| return null; | |||
adamsaghy
reviewed
Jan 21, 2025
| @@ -347,42 +357,6 @@ public void test_multi_disbursedAmt200_2ndOnDueDate_dayInYears360_daysInMonth30_ | |||
| checkPeriod(interestSchedule, 5, 0, 42.61, 0.007901833333, 0.33, 42.28, 0.0); | |||
| } | |||
|
|
|||
| @Test | |||
| public void test_reschedule_disbursedAmt100_dayInYears360_daysInMonth30_repayEvery1Month() { | |||
There was a problem hiding this comment.
Kinda, this was testing for the faulty behaviour, rewritten.
adamsaghy
reviewed
Jan 21, 2025
| @@ -183,4 +186,9 @@ public Integer getDaysInMonthType() { | |||
| public Integer getDaysInYearType() { | |||
| return daysInYearType.getValue(); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
I think we should move out from the loan product related details the term variations.
There was a problem hiding this comment.
i agree, moved it.
adamsaghy
requested changes
Jan 21, 2025
magyari-adam
force-pushed
the
feature/FINERACT-1981-b
branch
from
d2b6d3c to
31bd873
Compare
magyari-adam
force-pushed
the
feature/FINERACT-1981-b
branch
from
31bd873 to
a75acce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for progressive loan rescheduling.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.