Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] fix some sql statements doc #1930

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

chenzhx
Copy link
Contributor

@chenzhx chenzhx commented Jan 23, 2025

  • CREATE USER
  • ALTER USER
  • DROP USER
  • SET PASSWORD
  • CREATE ROLE
  • ALTER ROLE
  • DROP ROLE
  • SHOW ROLES

Versions

  • dev
  • 3.0
  • 2.1
  • 2.0

Languages

  • Chinese
  • English

Docs Checklist

  • Checked by AI
  • Test Cases Built

@wangtianyi2004
Copy link
Contributor

@wangtianyi2004
Copy link
Contributor

LGTM

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有一些共性问题,只评论在了其中一个文档中,麻烦所有文档都检查修改一下

Comment on lines 58 to 62
- PASSWORD_HISTORY [n|DEFAULT]
- PASSWORD_EXPIRE [DEFAULT|NEVER|INTERVAL n DAY/HOUR/SECOND]
- FAILED_LOGIN_ATTEMPTS n
- PASSWORD_LOCK_TIME [n DAY/HOUR/SECOND|UNBOUNDED]
- ACCOUNT_UNLOCK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分:

  1. 建议无序列表中写清楚类别。语法分到每一个类别中
  2. 每一个的语法还是要遵循语法部分的规范。参数要加上尖括号,可选部分使用大括号和竖线。举个例子
PASSWORD_EXPIRE { DEFAULT | NEVER | INTERVAL <n> { DAY | HOUR | SECOND } }

另外一种做法是,在语法部分把这些分支全部列清楚。然后在参数部分介绍每个分支的作用

Comment on lines 63 to 68
```sql
- PASSWORD_HISTORY [n|DEFAULT]
- PASSWORD_EXPIRE [DEFAULT|NEVER|INTERVAL n DAY/HOUR/SECOND]
- FAILED_LOGIN_ATTEMPTS n
- PASSWORD_LOCK_TIME [n DAY/HOUR/SECOND|UNBOUNDED]
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

与alter user 相同


The plaintext password is input in the PASSWORD() method; when using a string directly, the encrypted password needs to be passed.
To modify the passwords of other users, administrator privileges are required.
**<plain_password>**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 需要有序列表
  2. 需要反引号包裹,防止转义
Suggested change
**<plain_password>**
**1. `<plain_password>`**


## Example
> The input is a plaintext password.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里说的太笼统了。要解释清楚什么是plain text password。传递这种password时,实际会发生什么。会怎么影响登录


**<hashed_password>**

> The input is an encrypted password.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@KassieZ KassieZ added the has comments Some comments not resolved yet label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has comments Some comments not resolved yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants