Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-16999] Fix SensitiveDataConverter cannot convert empty data #17000

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

close #16999

Brief change log

  • Remove Duplicate SensitiveDataConverter in common module
  • Directly using ****** to replace sensitive data in SensitiveDataConverter.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Feb 7, 2025
@ruanwenjun ruanwenjun added the bug Something isn't working label Feb 7, 2025
@ruanwenjun ruanwenjun added this to the 3.3.0 milestone Feb 7, 2025
@ruanwenjun ruanwenjun changed the title [Fix-16999] Fix SensitiveDataConverter cannot convert empty data [Improvement-16999] Fix SensitiveDataConverter cannot convert empty data Feb 7, 2025
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly priority:low and removed bug Something isn't working priority:high labels Feb 7, 2025
Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit 934da2e into apache:dev Feb 8, 2025
70 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fix16991 branch February 8, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend document improvement make more easy to user or prompt friendly priority:low test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] SensitiveDataConverter cannot convert empty data
3 participants