Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16990] Fix WorkflowExecutionGraph#isTaskFinish is not working correctly #16995

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Feb 6, 2025

Purpose of the pull request

close #16990

Brief change log

  • Use inActiveTaskExecutionRunnable map to store task which has been executed
  • Add test case

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun added this to the 3.3.0 milestone Feb 6, 2025
@ruanwenjun ruanwenjun self-assigned this Feb 6, 2025
@ruanwenjun ruanwenjun added the bug Something isn't working label Feb 6, 2025
@ruanwenjun
Copy link
Member Author

cc @reele

@reele
Copy link
Contributor

reele commented Feb 6, 2025

cc @reele
got it!
i'm still reading the code to understand the logical completeness of WorkflowExecutionGraph.

Copy link

sonarqubecloud bot commented Feb 6, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit 879e966 into apache:dev Feb 7, 2025
69 of 70 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fix16990 branch February 7, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [WorkflowExecutionGraph] isTaskFinish method is not working correctly.
4 participants