[Bug] [WorkflowExecutionGraph] isTaskFinish method is not working correctly.

[reele]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

dolphinscheduler/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowExecutionGraph.java

Lines 294 to 296 in 4416548

	private boolean isTaskFinish(final ITaskExecutionRunnable taskExecutionRunnable) {
	return !activeTaskExecutionRunnable.contains(taskExecutionRunnable.getName());
	}

dolphinscheduler/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowExecutionGraph.java

Lines 165 to 172 in 4416548

	public boolean isTriggerConditionMet(final ITaskExecutionRunnable taskExecutionRunnable) {
	return getPredecessors(taskExecutionRunnable.getName())
	.stream()
	.allMatch(predecessor -> isTaskFinish(predecessor)
	&& !isTaskFailure(predecessor)
	&& !isTaskPaused(predecessor)
	&& !isTaskKilled(predecessor));
	}

when a task was never executed, it won't be found in activeTaskExecutionRunnable/failureTaskChains/pausedTaskChains/killedTaskChains.
isTaskFinish may return a wrong result:

I think there need to mark completed tasks in an explicit manner.

What you expected to happen

...

How to reproduce

set tasks in dag:
a -> b
b -> d
c -> d

when b never executed and c was finished, d will be executed.

Anything else

No response

Version

dev

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[ruanwenjun]

Good catch, we need to recursively judge whether its parents is in active list.