Fix failing extended sqlitetest on main / update datafusion-testing pin
#14940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strange it didn't fail in PR CI 🤔 |
Its because this job takes 2 hours to run so we don't run it on every PR... But that has the downside like this where it gets broken without us knowing |
alamb
changed the title
sqlite tests vai datafusion-testing pinsqlitetest on main / update datafusion-testing pin
|
@comphead can I beg a review for this one to get main running clean again? |
comphead
approved these changes
Feb 28, 2025
|
Thanks @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
CI is failing on main: https://github.com/apache/datafusion/actions/runs/13591237968/job/37997646819
Rationale for this change
The failure is due to accidentally changing the
datafusion-testingsubmodule pin inWhat changes are included in this PR?
Are these changes tested?
I tested them locally like this:
INCLUDE_SQLITE=true cargo test --profile release-nonlto --test sqllogictestsAre there any user-facing changes?