Add additional protobuf tests for plans that read parquet with projections #14924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
xudong963
approved these changes
Feb 28, 2025
|
@alamb wrong Marko :-) |
Sorry about that -- I meant @milenkovicm (but it was nice to see you online 👋 ) |
|
Thank you for the review @xudong963 |
|
thanks @alamb |
@blaginin and @mertak-synnada and @xudong963 did all the work to actually fix the issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I wanted to help #14679 by increasing test coverage (and so we were more confident in the fix in #14685 @blaginin 🙏 )
@mkmik proposed some nice tests in #14679 so I think it would be good to add test coverage directly
What changes are included in this PR?
SELECT ...from can be round tripped through protoufAre these changes tested?
They are only tests
Are there any user-facing changes?
There are no user facing changes