Fixed Migrate Datetime functions to invoke_with_args Issue 14705 #14792
Conversation
|
sir @goldmedal @alamb i am new in rust and this will be my first contribution please check my code and let me know if it is right or wrong ,i want to merge this change if there are any issue please let me know i will change them accordingly |
Welcome @varun-bhardwaj-sde. I enabled the CI. Some errors need to be fixed. I'll go over this after you're done. |
| internal_err!( | ||
| "invoke should not be called on a simplified current_date() function" | ||
| ) | ||
| fn invoke_with_args(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> { |
There was a problem hiding this comment.
The signature of the invoke_with_args should be:
fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue>.
You can check the ScalarUDFImpl trait in the datafusion::expr::udf crate.
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
|
Thank you @niebayes for helping with the review |
|
it was closed by misktake i raised another PR #14864 for this task |
Which issue does this PR close?
invoke_with_args#14705.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?