chore: Migrate Regex function to invoke_with_args #14728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
reviewed
Feb 17, 2025
| &[ColumnarValue::Scalar(v_sv), ColumnarValue::Scalar(regex_sv)], | ||
| 1, | ||
| ); | ||
| #[allow(deprecated)] |
There was a problem hiding this comment.
I think it is out of date. It's for inovke_batch but we have migrated to inovek_with_args. We can remove it.
There was a problem hiding this comment.
There are other similar parts. We can remove all of them.
| #[allow(deprecated)] | ||
| let re = RegexpCountFunc::new().invoke_with_args(ScalarFunctionArgs { | ||
| args: vec![ColumnarValue::Scalar(v_sv), ColumnarValue::Scalar(regex_sv)], | ||
| number_rows: 2, |
There was a problem hiding this comment.
I just noticed that it's different from the previous number 🤔. However, I think regexp_count never uses the number of rows. It's fine.
findepi
changed the title
|
Thanks @goldmedal , have modified according to your suggestion, PTAL. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
invoke_with_args#14707Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?