Migrate the internal and testing functions to invoke_with_args #14693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
approved these changes
Feb 16, 2025
| ) -> Result<ColumnarValue> { | ||
| let answer = match &args[0] { | ||
| fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> { | ||
| let answer = match &args.args[0] { |
There was a problem hiding this comment.
As a minor follow up, this could use take_function_args
goldmedal
deleted the
chore/migrate-test-inner-function-to-invoke-with-args
branch
|
Thanks @alamb for reviewing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ScalarUDF::invoke_batch#14652Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?