-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build "missing field sum_value
in initializer of ColumnStatistics
"
#14345
Conversation
missing field
sum_value in initializer of
ColumnStatistics``
missing field
sum_value in initializer of
ColumnStatistics``sum_value
in initializer of ColumnStatistics
sum_value
in initializer of ColumnStatistics
sum_value
in initializer of ColumnStatistics
"
Thank you for the quick review @findepi -- I will merge this once it passes tests |
I actually saw this in the extended tests ... I am watching those :) |
Thank you for the quick fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @alamb
All tests seem passed, let's merge and fix it. |
Well, I also broke it 😆 I don't want to be lauded as a fire fighter if I was also the one starting the fires 😆 🚒 I saw this a few times in my past lives and it is the wrong incentive |
Which issue does this PR close?
Closes #14347
Rationale for this change
CI is failing after I merged
ColumnStatistics::Sum
#14074https://github.com/apache/datafusion/actions/runs/13018845357/job/36314586166
What changes are included in this PR?
Fix compilation
Are these changes tested?
Are there any user-facing changes?