Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate function with typo in name (is_expr_constant_accross_partitions) #14252

Merged

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jan 23, 2025

Which issue does this PR close?

N/A

Rationale for this change

Fix typo in public API function

What changes are included in this PR?

  • Rename function to fix typo
  • Add deprecated function with original name

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Jan 23, 2025
#[deprecated(
since = "45.0.0",
note = "Use [`is_expr_constant_across_partitions`] instead"
)]
pub fn is_expr_constant_accross_partitions(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, thats the typo!

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @andygrove for clean this up

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🤦

@alamb alamb merged commit bd0b56f into apache:main Jan 23, 2025
26 checks passed
@alamb
Copy link
Contributor

alamb commented Jan 23, 2025

Thanks @comphead and @andygrove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Changes to the physical-expr crates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants