Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated dict_id in datafusion-proto (#14173) #14227

Conversation

cj-zhukov
Copy link
Contributor

Which issue does this PR close?

Closes #14173.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) common Related to common crate proto Related to proto crate labels Jan 22, 2025
@github-actions github-actions bot removed the common Related to common crate label Jan 29, 2025
@github-actions github-actions bot removed the optimizer Optimizer rules label Jan 30, 2025
@github-actions github-actions bot removed the physical-expr Physical Expressions label Jan 30, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that datafusion/core/src/physical_optimizer/enforce_sorting.rs somehow is added to this PR accidentally (it was moved on main recently, so perhaps this happened during a merge accidentally?)

Thanks for working on this @cj-zhukov

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cj-zhukov -- this is looking close

I also took the liberty of merging up from main and removing the accidentally added file

@github-actions github-actions bot added documentation Improvements or additions to documentation sql SQL Planner development-process Related to development process of DataFusion logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate common Related to common crate functions labels Feb 3, 2025
@cj-zhukov cj-zhukov force-pushed the cj-zhukov/Remove-use-of-deprecated-dict_id-in-datafusion-proto branch from 14c1e4d to 07157a7 Compare February 3, 2025 10:22
@github-actions github-actions bot removed documentation Improvements or additions to documentation sql SQL Planner development-process Related to development process of DataFusion logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate common Related to common crate functions labels Feb 3, 2025
@cj-zhukov
Copy link
Contributor Author

@alamb My apologies, I was trying to undo deletion of test in copy.slt with 07157a7 commit but accidentally added some PRs that should not be included here

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cj-zhukov

@andygrove are we happy that dict_id is no longer needed in DataFusion?

cc @thinkharderdev and @avantgardnerio who I think may have contributed the code for field_id originally

@andygrove
Copy link
Member

@andygrove are we happy that dict_id is no longer needed in DataFusion?

Yes, I think so. We have proven that we no longer need it in Comet, at least. Thanks for the ping.

@alamb
Copy link
Contributor

alamb commented Feb 6, 2025

@andygrove are we happy that dict_id is no longer needed in DataFusion?

Yes, I think so. We have proven that we no longer need it in Comet, at least. Thanks for the ping.

Interestingly enough when I am messing around in the arrow ipc code I still don't fully know how we will avoid it -- still working on that

@alamb
Copy link
Contributor

alamb commented Feb 11, 2025

I merged this PR locally and verified it compiles and passes tests, so merging it in

Thanks again @cj-zhukov

@alamb alamb merged commit c0e78d2 into apache:main Feb 11, 2025
25 checks passed
@cj-zhukov cj-zhukov deleted the cj-zhukov/Remove-use-of-deprecated-dict_id-in-datafusion-proto branch February 12, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proto Related to proto crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of deprecated dict_id in datafusion-proto
3 participants