-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of deprecated dict_id in datafusion-proto (#14173) #14227
Remove use of deprecated dict_id in datafusion-proto (#14173) #14227
Conversation
…n-datafusion-proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that datafusion/core/src/physical_optimizer/enforce_sorting.rs
somehow is added to this PR accidentally (it was moved on main recently, so perhaps this happened during a merge accidentally?)
Thanks for working on this @cj-zhukov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cj-zhukov -- this is looking close
I also took the liberty of merging up from main and removing the accidentally added file
14c1e4d
to
07157a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cj-zhukov
@andygrove are we happy that dict_id is no longer needed in DataFusion?
cc @thinkharderdev and @avantgardnerio who I think may have contributed the code for field_id originally
…of-deprecated-dict_id-in-datafusion-proto
Yes, I think so. We have proven that we no longer need it in Comet, at least. Thanks for the ping. |
Interestingly enough when I am messing around in the arrow ipc code I still don't fully know how we will avoid it -- still working on that |
I merged this PR locally and verified it compiles and passes tests, so merging it in Thanks again @cj-zhukov |
Which issue does this PR close?
Closes #14173.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?