Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utf8view support in nullif #13380

Merged
merged 1 commit into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions datafusion/functions/src/core/nullif.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ static SUPPORTED_NULLIF_TYPES: &[DataType] = &[
DataType::Int64,
DataType::Float32,
DataType::Float64,
DataType::Utf8View,
DataType::Utf8,
DataType::LargeUtf8,
];
Expand Down
30 changes: 30 additions & 0 deletions datafusion/sqllogictest/test_files/nullif.slt
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,33 @@ query I
SELECT NULLIF(NULL, NULL);
----
NULL

query T
SELECT NULLIF(arrow_cast('a', 'Utf8View'), 'a');
----
NULL

query T
SELECT NULLIF('a', arrow_cast('a', 'Utf8View'));
----
NULL

query T
SELECT NULLIF(arrow_cast('a', 'Utf8View'), 'b');
----
a

query T
SELECT NULLIF('a', arrow_cast('b', 'Utf8View'));
----
a

query T
SELECT NULLIF(null, arrow_cast('a', 'Utf8View'));
----
NULL

query T
SELECT NULLIF(arrow_cast('a', 'Utf8View'), null);
----
a
20 changes: 20 additions & 0 deletions datafusion/sqllogictest/test_files/string/string_view.slt
Original file line number Diff line number Diff line change
Expand Up @@ -934,6 +934,26 @@ logical_plan
01)Projection: to_timestamp(test.column1_utf8view, Utf8("a,b,c,d")) AS c
02)--TableScan: test projection=[column1_utf8view]

## Ensure no casts for nullif
query TT
EXPLAIN SELECT
nullif(column1_utf8view, 'a') as c
FROM test;
----
logical_plan
01)Projection: nullif(test.column1_utf8view, Utf8View("a")) AS c
02)--TableScan: test projection=[column1_utf8view]

## Ensure no casts for nullif
query TT
EXPLAIN SELECT
nullif(column1_utf8view, column1_utf8view) as c
FROM test;
----
logical_plan
01)Projection: nullif(test.column1_utf8view, test.column1_utf8view) AS c
02)--TableScan: test projection=[column1_utf8view]

## Ensure no casts for binary operators
# `~` operator (regex match)
query TT
Expand Down