-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support inner iejoin #12754
Open
my-vegetable-has-exploded
wants to merge
30
commits into
apache:main
Choose a base branch
from
my-vegetable-has-exploded:iejoin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,827
−26
Open
feat: support inner iejoin #12754
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0e478de
init iejoinexec.
my-vegetable-has-exploded 9b552cc
init executionplan.
my-vegetable-has-exploded 12da70e
wip
my-vegetable-has-exploded eca6cf8
basic implement iejoinstream.
my-vegetable-has-exploded d7d3dfd
..
my-vegetable-has-exploded b3b0e69
basic init.
my-vegetable-has-exploded 2dd0635
impl planner.
my-vegetable-has-exploded 24e516f
fix column index.
my-vegetable-has-exploded a8b509b
add ut.
my-vegetable-has-exploded 0c3a893
fix swap operator.
my-vegetable-has-exploded ffbf265
add sqllogicaltest.
my-vegetable-has-exploded f04021d
fix cargo.lock.
my-vegetable-has-exploded acd8474
rm useless dependcy.
my-vegetable-has-exploded 007c00b
fix sort partition.
my-vegetable-has-exploded ca296d3
fix test string.
my-vegetable-has-exploded b6633a7
fix tests & clippy
my-vegetable-has-exploded 8110ecd
fix test contain.
my-vegetable-has-exploded 4d48810
fix sort removed.
my-vegetable-has-exploded 44d5f76
add more tests.
my-vegetable-has-exploded 246811a
test generate_series.
my-vegetable-has-exploded 4c3bd6c
test generate_series.
my-vegetable-has-exploded 8c819a9
add more comments.
my-vegetable-has-exploded 1738495
add metric
my-vegetable-has-exploded a67a720
fix permutation len.
my-vegetable-has-exploded 9fcd867
fix metric
my-vegetable-has-exploded 698fb5c
fix comment.
my-vegetable-has-exploded b246e7e
little update.
my-vegetable-has-exploded cde1f8f
use left_order.
my-vegetable-has-exploded dea673a
fix tests.
my-vegetable-has-exploded 7d03765
fix clippy.
my-vegetable-has-exploded File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add more comments.
commit 8c819a923e1bda623f9473cf173bfb3820cdc849
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my test, use btreemap is a little faster than bitmap (https://github.com/my-vegetable-has-exploded/arrow-datafusion/compare/iejoin...my-vegetable-has-exploded:arrow-datafusion:iejoin-bitmap?expand=1), 8.5s -> 7.5s. Currently, the main cost is sorting though.