Fixes missing nth_value UDAF expr function
#12279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
proto
jcsherin
commented
Sep 1, 2024
Comment on lines
43
to
59
| /// Returns the nth value in a group of values. | ||
| pub fn nth_value( | ||
| expr: datafusion_expr::Expr, | ||
| n: i64, | ||
| order_by: Option<Vec<SortExpr>>, | ||
| ) -> datafusion_expr::Expr { | ||
| let args = vec![expr, lit(n)]; | ||
| if let Some(order_by) = order_by { | ||
| nth_value_udaf() | ||
| .call(args) | ||
| .order_by(order_by) | ||
| .build() | ||
| .unwrap() | ||
| } else { | ||
| nth_value_udaf().call(args) | ||
| } | ||
| } |
jayzhan211
reviewed
Sep 2, 2024
jayzhan211
reviewed
Sep 2, 2024
| pub fn nth_value( | ||
| expr: datafusion_expr::Expr, | ||
| n: i64, | ||
| order_by: Option<Vec<SortExpr>>, |
There was a problem hiding this comment.
Do we need Option for no ordering case? Can we represent no ordering case with empty vec?
There was a problem hiding this comment.
You are right. The option type is extraneous here. I'll make this change.
|
I lack permission to apply the |
|
Thanks @jcsherin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12278.
Rationale for this change
Same as #12278.
What changes are included in this PR?
The API in v40 is:
A better API would be this:
Are these changes tested?
Yes. Logical roundtrip tests, both with and without order by expression.
Are there any user-facing changes?
Yes, this is a breaking change of user-facing API.