Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Use slice in ConcreteTreeNode #10666

Merged
merged 1 commit into from
May 26, 2024

Conversation

peter-toth
Copy link
Contributor

The idea of using slices to return a node's children came up here: #10543 (comment).
While it is not possible in all TreeNode implementations, the 2 ConcreteTreeNode implementations (ExprContext and PlanContext) own their children in Vec form, so there is a way to return a slice like &[Self] (instead of the current Vec<&Self>).

@alamb alamb added the api change Changes the API exposed to users of the crate label May 26, 2024
@alamb alamb merged commit e40f50b into apache:main May 26, 2024
23 checks passed
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request May 26, 2024
@peter-toth
Copy link
Contributor Author

Thanks @alamb for the review!

findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants