-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce user-defined signature #10439
Merged
+359
−124
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ff441ea
introduce new sig
jayzhan211 8b6016b
add udfimpl
jayzhan211 36abe3e
replace fun
jayzhan211 0988efe
replace array
jayzhan211 a64b813
coalesce
jayzhan211 5bbd2a0
nvl2
jayzhan211 6f0a90b
rm variadic equal
jayzhan211 5cc047b
fix test
jayzhan211 a515aad
rm err msg to fix ci
jayzhan211 17e6ec1
user defined sig
jayzhan211 5eaacc8
add err msg
jayzhan211 a606581
fmt
jayzhan211 40d5444
cleanup
jayzhan211 ca7f942
fix ci
jayzhan211 5cb0d0f
fix ci
jayzhan211 68fdf52
upd comment
jayzhan211 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix ci
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
commit 5cb0d0f3eb9561aec71add75d595022aa2f1b1e2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think matching err message is unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the message is tested elsewhere I think this is fine