Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that comments aren't preserved for round trip #1060

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Document that comments aren't preserved for round trip #1060

merged 1 commit into from
Dec 19, 2023

Conversation

takluyver
Copy link
Contributor

From discussion on #1052.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7052192921

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 87.706%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 1 11.92%
Totals Coverage Status
Change from base Build 7009122777: 0.0%
Covered Lines: 17992
Relevant Lines: 20514
💛 - Coveralls

@alamb alamb mentioned this pull request Dec 19, 2023
Closed
7 tasks
alamb
alamb approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @takluyver 🙏

@alamb alamb merged commit e027b3c into apache:main Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobyhede tobyhede tobyhede approved these changes

@alamb alamb alamb approved these changes

@lovasoa lovasoa lovasoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@takluyver @coveralls @tobyhede @alamb @lovasoa