Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to simplify the rest server #11

Merged
merged 1 commit into from
Feb 10, 2016

Conversation

andreaturli
Copy link
Contributor

  • remove JsonNode from API interfaces
  • refactor consistently toStringand hashCode and equals for the domain objects
  • remove deprecated code
  • simplified pom dependencies
  • remove com.codehaus.jackson dependency and promote com.fasterxml.jackson usage
  • adjust BrooklynJacksonSerializer to use jackson 2 api
  • fix web.xml for rest-api and rest-client
  • update feature.xml dependencies, following maven dependency changes

@andreaturli
Copy link
Contributor Author

This PR is a porting of apache/incubator-brooklyn#1177 to the new repo.

@neykov
Copy link
Member

neykov commented Feb 10, 2016

Looks great. Can you remove 'pom.xml.orig' and I'll merge it.

- remove JsonNode from API interfaces
- refactor consistently toStringand hashCode and equals for the domain objects
- remove deprecated code
- simplified pom dependencies
- remove com.codehaus.jackson dependency and promote com.fasterxml.jackson usage
- adjust BrooklynJacksonSerializer to use jackson 2 api
- fix web.xml for rest-api and rest-client
- update feature.xml dependencies, following maven dependency changes
@andreaturli andreaturli force-pushed the improvements/rest-api branch from 20b8600 to 1a53a3f Compare February 10, 2016 08:22
@andreaturli
Copy link
Contributor Author

thanks @neykov for your review.

  • removed pom.xml.origin - not sure why it was there, sorry :(
  • rebased and squashed

let's wait for jenkins and eventually merge it

@neykov
Copy link
Member

neykov commented Feb 10, 2016

Failure is unrelated and builds fine on my machine. Merging.

@asfgit asfgit merged commit 1a53a3f into apache:master Feb 10, 2016
asfgit pushed a commit that referenced this pull request Feb 10, 2016
Initial work to simplify the rest server

- remove JsonNode from API interfaces
- refactor consistently toStringand hashCode and equals for the domain objects
- remove deprecated code
- simplified pom dependencies
- remove com.codehaus.jackson dependency and promote com.fasterxml.jackson usage
- adjust BrooklynJacksonSerializer to use jackson 2 api
- fix web.xml for rest-api and rest-client
- update feature.xml dependencies, following maven dependency changes
@neykov neykov mentioned this pull request Feb 12, 2016
grkvlt pushed a commit to grkvlt/brooklyn-server that referenced this pull request Jun 12, 2017
Fix: duplicate provisioning.properties
asfgit pushed a commit that referenced this pull request Oct 4, 2021
Configurable exclude-list of tokens for DSL values of sensitive field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants