-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial work to simplify the rest server #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andreaturli
commented
Feb 9, 2016
- remove JsonNode from API interfaces
- refactor consistently toStringand hashCode and equals for the domain objects
- remove deprecated code
- simplified pom dependencies
- remove com.codehaus.jackson dependency and promote com.fasterxml.jackson usage
- adjust BrooklynJacksonSerializer to use jackson 2 api
- fix web.xml for rest-api and rest-client
- update feature.xml dependencies, following maven dependency changes
This PR is a porting of apache/incubator-brooklyn#1177 to the new repo. |
andreaturli
force-pushed
the
improvements/rest-api
branch
from
February 9, 2016 09:39
cdb49fa
to
20b8600
Compare
Looks great. Can you remove 'pom.xml.orig' and I'll merge it. |
- remove JsonNode from API interfaces - refactor consistently toStringand hashCode and equals for the domain objects - remove deprecated code - simplified pom dependencies - remove com.codehaus.jackson dependency and promote com.fasterxml.jackson usage - adjust BrooklynJacksonSerializer to use jackson 2 api - fix web.xml for rest-api and rest-client - update feature.xml dependencies, following maven dependency changes
andreaturli
force-pushed
the
improvements/rest-api
branch
from
February 10, 2016 08:22
20b8600
to
1a53a3f
Compare
thanks @neykov for your review.
let's wait for jenkins and eventually merge it |
Failure is unrelated and builds fine on my machine. Merging. |
asfgit
pushed a commit
that referenced
this pull request
Feb 10, 2016
Initial work to simplify the rest server - remove JsonNode from API interfaces - refactor consistently toStringand hashCode and equals for the domain objects - remove deprecated code - simplified pom dependencies - remove com.codehaus.jackson dependency and promote com.fasterxml.jackson usage - adjust BrooklynJacksonSerializer to use jackson 2 api - fix web.xml for rest-api and rest-client - update feature.xml dependencies, following maven dependency changes
Merged
grkvlt
pushed a commit
to grkvlt/brooklyn-server
that referenced
this pull request
Jun 12, 2017
Fix: duplicate provisioning.properties
asfgit
pushed a commit
that referenced
this pull request
Oct 4, 2021
Configurable exclude-list of tokens for DSL values of sensitive field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.