Skip to content

Commit

Permalink
Use slf4j-bom and log4j-bom in dependencyManagement (#4346)
Browse files Browse the repository at this point in the history
### Motivation

When using SLF4J 2.0.x, it's useful to use slf4j-bom to align slf4j library versions. This is necessary to ensure that logging doesn't break due to mixed slf4j library versions.
Similarly, it's useful to use log4j-bom to align log4j library versions.
SLF4J 2.0.x upgrade was made in PR #4248 .

### Changes

- use slf4j-bom and log4j-bom in dependencyManagement
  • Loading branch information
lhotari authored May 6, 2024
1 parent de5a4f2 commit 1ae4be0
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -242,18 +242,17 @@
<!-- logging dependencies -->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<artifactId>slf4j-bom</artifactId>
<version>${slf4j.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
<version>${log4j.version}</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j2-impl</artifactId>
<artifactId>log4j-bom</artifactId>
<version>${log4j.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>com.lmax</groupId>
Expand Down

0 comments on commit 1ae4be0

Please sign in to comment.