-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45628: [C++] Ensure specifying Boost include directory for bundled Thrift #45637
Conversation
@github-actions crossbow submit -g cpp -g python -g r |
|
Revision: 387a1b5 Submitted crossbow builds: ursacomputing/crossbow @ actions-00f2b3f5b5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem from me.
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0fbf982. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We must use the Boost for Apache Arrow C++ itself and bundled libraries including Apache Thrift. We can enforce it by specifying the target Boost explicitly instead of detecting Boost in each bundled libraries.
What changes are included in this PR?
Always specify
-DBoost_INCLUDE_DIR
.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.