GH-45620: [CI][C++] Use Visual Studio 2022 not 2019 #45621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
force-pushed
the
ci-cpp-visual-studio-2022
branch
from
7ff6abb to
0cbd961
Compare
pitrou
reviewed
Feb 25, 2025
pitrou
approved these changes
Feb 25, 2025
arashandishgar
pushed a commit
to arashandishgar/arrow
that referenced
this pull request
Feb 25, 2025
### Rationale for this change It seems that Visual Studio 2019 is in maintenance mode: https://learn.microsoft.com/en-us/visualstudio/releases/2019/servicing-vs2019 ### What changes are included in this PR? Use Visual Studio 2022 on `windows-2022` image. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45620 Lead-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 46f8544. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It seems that Visual Studio 2019 is in maintenance mode: https://learn.microsoft.com/en-us/visualstudio/releases/2019/servicing-vs2019
What changes are included in this PR?
Use Visual Studio 2022 on
windows-2022image.Are these changes tested?
Yes.
Are there any user-facing changes?
No.