Remove duplicated symbol, expose new required symbols

apache · Feb 27, 2025 · de11ab2 · de11ab2
1 parent 2d26f3d
commit de11ab2
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 8 deletions.
diff --git a/cpp/src/arrow/compute/kernels/aggregate_basic.cc b/cpp/src/arrow/compute/kernels/aggregate_basic.cc
@@ -16,6 +16,7 @@
 // under the License.
 
 #include "arrow/compute/api_aggregate.h"
+#include "arrow/compute/codegen_internal.h"
 #include "arrow/compute/kernels/aggregate_basic_internal.h"
 #include "arrow/compute/kernels/aggregate_internal.h"
 #include "arrow/compute/kernels/common_internal.h"

diff --git a/cpp/src/arrow/compute/kernels/codegen_internal.h b/cpp/src/arrow/compute/kernels/codegen_internal.h
@@ -473,8 +473,6 @@ static void VisitTwoArrayValuesInline(const ArraySpan& arr0, const ArraySpan& ar
 
 // ----------------------------------------------------------------------
 // Reusable type resolvers
-
-Result<TypeHolder> FirstType(KernelContext*, const std::vector<TypeHolder>& types);
 Result<TypeHolder> LastType(KernelContext*, const std::vector<TypeHolder>& types);
 Result<TypeHolder> ListValuesType(KernelContext* ctx,
                                   const std::vector<TypeHolder>& types);
@@ -1398,16 +1396,17 @@ void ReplaceTypes(const TypeHolder& replacement, std::vector<TypeHolder>* types)
 
 void ReplaceTypes(const TypeHolder& replacement, TypeHolder* types, size_t count);
 
-void ReplaceTemporalTypes(TimeUnit::type unit, std::vector<TypeHolder>* types);
+ARROW_COMPUTE_EXPORT void ReplaceTemporalTypes(TimeUnit::type unit,
+                                               std::vector<TypeHolder>* types);
 
 TypeHolder CommonNumeric(const std::vector<TypeHolder>& types);
 
 TypeHolder CommonNumeric(const TypeHolder* begin, size_t count);
 
-TypeHolder CommonTemporal(const TypeHolder* begin, size_t count);
+ARROW_COMPUTE_EXPORT TypeHolder CommonTemporal(const TypeHolder* begin, size_t count);
 
-bool CommonTemporalResolution(const TypeHolder* begin, size_t count,
-                              TimeUnit::type* finest_unit);
+ARROW_COMPUTE_EXPORT bool CommonTemporalResolution(const TypeHolder* begin, size_t count,
+                                                   TimeUnit::type* finest_unit);
 
 TypeHolder CommonBinary(const TypeHolder* begin, size_t count);
 
@@ -1421,11 +1420,12 @@ enum class DecimalPromotion : uint8_t {
 /// Given two arguments, at least one of which is decimal, promote all
 /// to not necessarily identical types, but types which are compatible
 /// for the given operator (add/multiply/divide).
-Status CastBinaryDecimalArgs(DecimalPromotion promotion, std::vector<TypeHolder>* types);
+ARROW_COMPUTE_EXPORT Status CastBinaryDecimalArgs(DecimalPromotion promotion,
+                                                  std::vector<TypeHolder>* types);
 
 /// Given one or more arguments, at least one of which is decimal,
 /// promote all to an identical type.
-Status CastDecimalArgs(TypeHolder* begin, size_t count);
+ARROW_COMPUTE_EXPORT Status CastDecimalArgs(TypeHolder* begin, size_t count);
 
 bool HasDecimal(const std::vector<TypeHolder>& types);
 

diff --git a/cpp/src/arrow/compute/kernels/hash_aggregate.cc b/cpp/src/arrow/compute/kernels/hash_aggregate.cc
@@ -29,6 +29,7 @@
 #include "arrow/buffer_builder.h"
 #include "arrow/compute/api_aggregate.h"
 #include "arrow/compute/api_vector.h"
+#include "arrow/compute/codegen_internal.h"
 #include "arrow/compute/kernel.h"
 #include "arrow/compute/kernels/aggregate_internal.h"
 #include "arrow/compute/kernels/aggregate_var_std_internal.h"

diff --git a/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc b/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
@@ -25,6 +25,7 @@
 #include "arrow/compare.h"
 #include "arrow/compute/api_scalar.h"
 #include "arrow/compute/cast.h"
+#include "arrow/compute/codegen_internal.h"
 #include "arrow/compute/kernels/base_arithmetic_internal.h"
 #include "arrow/compute/kernels/codegen_internal.h"
 #include "arrow/compute/kernels/common_internal.h"

diff --git a/cpp/src/arrow/compute/kernels/scalar_if_else.cc b/cpp/src/arrow/compute/kernels/scalar_if_else.cc
@@ -21,6 +21,7 @@
 #include "arrow/array/builder_time.h"
 #include "arrow/array/builder_union.h"
 #include "arrow/compute/api.h"
+#include "arrow/compute/codegen_internal.h"
 #include "arrow/compute/kernels/codegen_internal.h"
 #include "arrow/compute/kernels/copy_data_internal.h"
 #include "arrow/result.h"

diff --git a/cpp/src/arrow/compute/kernels/scalar_round.cc b/cpp/src/arrow/compute/kernels/scalar_round.cc
@@ -25,6 +25,7 @@
 #include "arrow/compare.h"
 #include "arrow/compute/api_scalar.h"
 #include "arrow/compute/cast.h"
+#include "arrow/compute/codegen_internal.h"
 #include "arrow/compute/kernel.h"
 #include "arrow/compute/kernels/base_arithmetic_internal.h"
 #include "arrow/compute/kernels/codegen_internal.h"

diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
@@ -21,6 +21,7 @@
 
 #include "arrow/builder.h"
 #include "arrow/compute/api_scalar.h"
+#include "arrow/compute/codegen_internal.h"
 #include "arrow/compute/kernels/common_internal.h"
 #include "arrow/compute/kernels/temporal_internal.h"
 #include "arrow/util/checked_cast.h"

diff --git a/cpp/src/arrow/compute/kernels/vector_hash.cc b/cpp/src/arrow/compute/kernels/vector_hash.cc
@@ -29,6 +29,7 @@
 #include "arrow/buffer.h"
 #include "arrow/compute/api_vector.h"
 #include "arrow/compute/cast.h"
+#include "arrow/compute/codegen_internal.h"
 #include "arrow/compute/kernels/common_internal.h"
 #include "arrow/result.h"
 #include "arrow/util/hashing.h"

diff --git a/cpp/src/arrow/compute/kernels/vector_replace.cc b/cpp/src/arrow/compute/kernels/vector_replace.cc
@@ -16,6 +16,7 @@
 // under the License.
 
 #include "arrow/compute/api_scalar.h"
+#include "arrow/compute/codegen_internal.h"
 #include "arrow/compute/kernels/common_internal.h"
 #include "arrow/compute/kernels/copy_data_internal.h"
 #include "arrow/compute/kernels/util_internal.h"

diff --git a/cpp/src/arrow/compute/kernels/vector_selection_internal.cc b/cpp/src/arrow/compute/kernels/vector_selection_internal.cc
@@ -27,6 +27,7 @@
 #include "arrow/buffer_builder.h"
 #include "arrow/chunked_array.h"
 #include "arrow/compute/api_vector.h"
+#include "arrow/compute/codegen_internal.h"
 #include "arrow/compute/function.h"
 #include "arrow/compute/kernel.h"
 #include "arrow/compute/kernels/codegen_internal.h"