Expose min/max values for Decimal128/256 and improve docs #6992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynexia
approved these changes
Jan 21, 2025
| /// [`Decimal128`]: arrow_schema::DataType::Decimal128 | ||
| #[deprecated( | ||
| since = "54.1.0", | ||
| note = "Use MAX_DECIMAL128_FOR_EACH_PRECISION (note indexes are different)" |
|
Thank you for the review @waynexia |
|
I will plan to merge this PR tomorrow unless anyone else would like time to comment |
alamb
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We need to know the min/max values for
Decimal128andDecimal256in Datafusion (see apache/datafusion#14126 from @waynexia )Currently only the min/max values are exposed for
Decimal128Also it turns out that the exposed values is different than what is currently used, which is confusing
What changes are included in this PR?
Decimal128andDecimal256pub(crate)constants to be consistentpubconstantsAre there any user-facing changes?
Yes, deprecated some constants and made others public