Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): remove lualdap deps #11829

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(ci): remove lualdap deps #11829

merged 1 commit into from
Dec 16, 2024

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Dec 16, 2024 •
edited
Loading

Description

fix: https://github.com/apache/apisix/actions/runs/12293837387/job/34451936593?pr=11824#step:5:22314

The current version of lualdap has been archived: https://luarocks.org/modules/fperrad/lualdap

img_v3_02hj_f505a433-b18d-45ba-811c-ea12bd9f2c5g

fix

I noticed that the implementation of ldap-auth has been replaced, and the lualdap dependency has not been used. So I think it needs to be removed.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@AlinsRan AlinsRan marked this pull request as ready for review December 16, 2024 05:34
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. CI dependencies Pull requests that update a dependency file labels Dec 16, 2024
@Revolyssup Revolyssup self-requested a review December 16, 2024 06:45
@shreemaan-abhishek shreemaan-abhishek merged commit e3c904a into apache:master Dec 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@Revolyssup Revolyssup Revolyssup approved these changes

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

Assignees
No one assigned
Labels
CI dependencies Pull requests that update a dependency file size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlinsRan @membphis @Revolyssup @shreemaan-abhishek