-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(body-transformer): support mulipart content-type #11767
Merged
Revolyssup
merged 7 commits into
apache:master
from
Revolyssup:revolyssup/support-multipart-content
Nov 29, 2024
Merged
feat(body-transformer): support mulipart content-type #11767
Revolyssup
merged 7 commits into
apache:master
from
Revolyssup:revolyssup/support-multipart-content
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port-multipart-content
shreemaan-abhishek
previously approved these changes
Nov 22, 2024
shreemaan-abhishek
previously approved these changes
Nov 22, 2024
@membphis can you review this? |
membphis
previously approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except one minor thing
apisix/plugins/body-transformer.lua
Outdated
@@ -184,6 +201,8 @@ local function set_input_format(conf, typ, ct, method) | |||
conf[typ].input_format = "json" | |||
elseif str_find(ct:lower(), "application/x-www-form-urlencoded", nil, true) then | |||
conf[typ].input_format = "encoded" | |||
elseif str_find(ct:lower(), "multipart/", nil) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revolyssup
commented
Nov 25, 2024
e374a62
membphis
approved these changes
Nov 25, 2024
shreemaan-abhishek
approved these changes
Nov 25, 2024
moonming
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
plugin
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
multipart
content-type in body-transformer plugin.Fixes # (issue)
Checklist